Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add support for inv sequence (revert #340) #357

Closed
reece opened this issue Sep 15, 2016 · 2 comments
Closed

Re-add support for inv sequence (revert #340) #357

reece opened this issue Sep 15, 2016 · 2 comments
Labels
enhancement New feature or request
Milestone
0.4.x

Comments

@reece
Copy link
Member

reece commented Sep 15, 2016

Originally reported by: Reece Hart (Bitbucket: reece, GitHub: reece)

Current varnomen recommendations are (implicitly) to not include sequence after 'inv'.
http://varnomen.hgvs.org/recommendations/DNA/variant/inversion/

Mutnomen recommendations from Dec 2015 do allow for sequence after 'inv'.
https://web.archive.org/web/20151213043001/http://www.hgvs.org/mutnomen/examplesDNA.html#inv

In issue #340, support for sequences after inversions was removed. This causes breakage to users. Investigate adding it back, and do so if there are no downsides.
@reece
Copy link
Member Author

reece commented Sep 15, 2016

Original comment by Reece Hart (Bitbucket: reece, GitHub: reece):

fixed #357: reenable parsing of sequence with inversion (backed out #340)

1 similar comment
@reece
Copy link
Member Author

reece commented Sep 15, 2016

Original comment by Reece Hart (Bitbucket: reece, GitHub: reece):

fixed #357: reenable parsing of sequence with inversion (backed out #340)

@reece reece added minor enhancement New feature or request labels Mar 9, 2017
@reece reece added this to the 0.4.x milestone Mar 9, 2017
@reece reece closed this as completed Mar 9, 2017
reece added a commit that referenced this issue Apr 21, 2019
@reece
fixed #357: reenable parsing of sequence with inversion (backed out #340
a6b28c0 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.4.x
Development

No branches or pull requests
1 participant
@reece