Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validation should directly raise only HGVSInvalidVariantError #399

Closed
reece opened this issue Mar 9, 2017 · 2 comments
Closed

validation should directly raise only HGVSInvalidVariantError #399

reece opened this issue Mar 9, 2017 · 2 comments
Labels
enhancement New feature or request
Milestone
1.0.0

Comments

@reece
Copy link
Member

reece commented Mar 9, 2017

Originally reported by: Reece Hart (Bitbucket: reece, GitHub: reece)

When validating a variant, IntrinsicValidator and ExtrinsicValidator should raise only HGVSInvalidVariantError on error, regardless of the strict setting. It's confusing if the validators return different exceptions based on the strict setting.
@reece
Copy link
Member Author

reece commented Mar 9, 2017

Original comment by Reece Hart (Bitbucket: reece, GitHub: reece):

closes #399: validators should raise only HGVSInvalidVariantError exceptins

@reece
Copy link
Member Author

reece commented Mar 9, 2017

Original comment by Reece Hart (Bitbucket: reece, GitHub: reece):

Merged in validation-should-raise-only-ive (pull request #62)

closes #399: validators should raise only HGVSInvalidVariantError exceptions

Approved-by: Meng Wang

@reece reece added minor enhancement New feature or request labels Mar 9, 2017
@reece reece added this to the 0.5.0 milestone Mar 9, 2017
@reece reece closed this as completed Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@reece