Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes missing license information on anaconda.org #4419

Closed
peterjc opened this issue Apr 13, 2017 · 8 comments
Closed

Sometimes missing license information on anaconda.org #4419

peterjc opened this issue Apr 13, 2017 · 8 comments

Comments

@peterjc
Copy link
Contributor

peterjc commented Apr 13, 2017

Consider these examples (mostly tools I am familiar with, picked to show three different licenses):

vs

Bioconda contains a mix of both "MIT License" and "MIT" (and variants thereof), so initially I wondered if Anaconda.org using a restricted vocabulary - but that alone does not explain the toolshed vs pyani example (which differ in their license_family entry).

Likewise Bioconda contains a mix of both "BSD-3-clause", "BSD 3-clause", "3-Clause BSD", etc - and at least some of the time Anaconda shows them.

Is there a convention used on Anaconda.org about the license metadata which BioConda is not consistently following?

@daler
Copy link
Member

daler commented Apr 13, 2017

This is a good point and something that we've not been good about. #1581 was a start at looking at consistency, and once we have a controlled vocabulary we can add it to the linting system to catch issues with new recipes.

Like you mentioned, anaconda.org seems to be showing "unspecified" if a license_family or license_file key is included. This seems like an anaconda.org bug.

I'm not aware of any license list that anaconda.org uses. Though I guess when there's a question we could use the "SPDX short identifier" from OSI, so for example BSD 3-clause would have dashes as in https://opensource.org/licenses/BSD-3-Clause. Not all licences have those identifiers though.

@peterjc
Copy link
Contributor Author

peterjc commented Apr 14, 2017

I agree whatever is breaking seems to be an anaconda.org bug.

I'm not sure if license_file is important, consider:

Consider these examples:

Assuming both recipes match the current files on bioconda.github.io and anaconda.org then only one of these uses license_file, but neither has its license shown properly.

about:
  home: https://github.com/nanoporetech/wub
  license: MPL-2.0
  license_file: LICENSE.md
  summary: 'Tools and software library developed by the ONT Applications group'

vs

about:
  home: https://github.com/nanoporetech/nanonet
  license: MPL-2.0
  summary: Nanonet provides recurrent neural network basecalling for Oxford Nanopore MinION data.

@peterjc
Copy link
Contributor Author

peterjc commented May 2, 2017

https://github.com/Anaconda-Platform/support/issues/105#issuecomment-298687862

Apparently this should be fixed on anaconda-client 1.6.3.

Does this mean we need to do a push from the Bioconda side?

@bgruening
Copy link
Member

Interesting! I don't understand why but yes it seems so. So we need to wait until a rebuild of a package triggers a new push :(

@bgruening
Copy link
Member

@peterjc is this still an issue? Please note that the bot is not also checking for the presence of a license file. We have a long way to go to clean license information, but hopefully, our collaboration with Debian and bio.tools will help here.

@peterjc
Copy link
Contributor Author

peterjc commented Sep 30, 2019

All the examples above work now, except:

https://bioconda.github.io/recipes/nanonet/README.html showing: MPL-2.0
https://anaconda.org/bioconda/nanonet showing License: Unspecified
https://github.com/bioconda/bioconda-recipes/blob/master/recipes/nanonet/meta.yaml showing: MPL-2.0

However, as the package has not been updated for over 2 years, that fits. Hopefully the bot will flag this repository shortly as it lacks a license file?

@druvus
Copy link
Member

druvus commented Sep 30, 2019

It seems that ONT completely removed the sources for nanonet.

@peterjc
Copy link
Contributor Author

peterjc commented Sep 30, 2019

We can close this then I think

@peterjc peterjc closed this as completed Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants