-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Percolator: pin xercesc and boost version #11871
Conversation
Leon-Bichmann
commented
Nov 9, 2018
- [x ] I have read the guidelines for bioconda recipes.
- This PR adds a new recipe.
- AFAIK, this recipe is directly relevant to the biological sciences (otherwise, please submit to the more general purpose conda-forge channel).
- [x ] This PR updates an existing recipe.
- This PR does something else (explain below).
Can you comment on why you need to pin boost? |
Hey,
So I was hoping pining boost would solve that conflict. And I assume most people would use percolator and openms in combination. |
@@ -16,11 +16,11 @@ requirements: | |||
- {{ compiler('c') }} | |||
host: | |||
- zlib | |||
- boost | |||
- boost = 1.64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we can use boost-cpp here ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Leon-Bichmann ideally we could convince openms to use the latest boost version. Do you have time to try this?
I actually didn't have any problem running |
@bgruening What's actually the difference between |
That's probably because you didn't get The big catch with boost is that it's ABI is highly unstable. If you compiled a tool with 1.67, the binaries (hence ABI) will be incompatible with any other version. To make matters worse, they release very frequently (quarterly). The approach taken by the major Linux distros - split boost into dozens of small packages and give each release a new package (i.e. So all we can do is pin to limit the frequency of updates, and rebuild everything depending on boost every time the pin changes. We don't have a mechanism to do the rebuild yet, so there may be packages that have been built with an older boost around, and hence won't work with the current 1.67. You can trigger a rebuild by just bumping the build number. If you need a specific version rebuilt (2.4), you'd need to create a sub folder (e.g. openms/2.4) and put the resurrected state of the recipe at version 2.4 in there. |
@MatthewThe do you have an idea how to fix this conflict? |
@epruesse Yup, actually an older one, gave me |
I don't think upgrading the boost version should be a problem for percolator. However, @glormph created the percolator recipe on bioconda, so he probably knows better. |
@Leon-Bichmann this is also in my interest since I (also) have to do something similar for for nf-core who prefer one-docker-image for a whole pipeline :). But it's been a long time since I worked on the bioconda recipe so I'm a bit lost. As for the diff between boost and boost-cpp, the only thing I could quickly find is that the boost feedstock passes this to its
As opposed to the boost-cpp feedstock (builds without python). But what is the actual problem here? I agree with @bgruening that it would be ideal to make the openms recipe use a later boost, but if that fails, I guess it works to do what you created a PR for? The PR checks out, right? |
Ok I think in any case this pull request is not usefull |