Added a missing file for Kaiju #19977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaiju-excluded-accessions.txt was added in the newest release
|
@BiocondaBot please add label |
pvanheus
approved these changes
Jan 26, 2020
There was a problem hiding this comment.
Since the location of this file is hard coded by the program the proposed solution seems to be the only correct one. So I vote +1 for accepting this.
|
Thank you very much. |
|
looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kaiju-excluded-accessions.txtwas added in the newest release. Without it,kaiju-makedbcrashes for me on the latest version (1.7.3).It is available next to the executables. Is it ok to place it in the bin dir? The same thing is done for the
kaiju-taxonlistEuk.tsv. The location is hard coded.@pmenzel Just tagged you to notify you of this proposed change.