ncbi-amrfinderplus: Update Add test for Mac installation bug #21613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current public version of AMRFinderPlus is failing to install on the Mac. This is to add a test to exercise that fact and see if it passes.
|
We are working on a new release of AMRFinderPlus that should fix the test issues. |
dfornika
changed the title
|
Everything looks good now for the new release |
dfornika
approved these changes
May 14, 2020
|
@BiocondaBot please fetch artifacts |
|
No artifacts found on the most recent CircleCI build. Either the build failed or the recipe was blacklisted/skipped. |
|
@BiocondaBot please merge |
|
I will attempt to upload artifacts and merge this PR. This may take some time, please have patience. |
|
@dfornika Thanks for your help! In previous pull requests (I think they've all been autobump generated) I've been able to approve and merge, but I didn't see a way to do it for this one. |
|
@evolarjun I'm not certain but I think there's a rule against merging your own PRs. |
a-solovyev12
pushed a commit
to ebi-gene-expression-group/bioconda-recipes
that referenced
this pull request
Jun 29, 2020
Merge PR bioconda#21613, commits were: * Oops I misunderstood how this related to another PR * Bump build number * Update sha256sum * Reset build number to 0 * Updated for new hopefully fixed release 3.8.4 * Remove some debugging output * Add test for Mac installation bug The current public version of AMRFinderPlus is failing to install on the Mac. This is to add a test to exercise that fact and see if it passes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current public version of AMRFinderPlus is failing to install on the
Mac. This is to add a test to exercise that fact and see if it passes.
Describe your pull request here
There is a bug in the Mac bioconda install and this pull request just adds a test
to (hopefully) exercise it. Once we know the CircleCI test is failing on the Mac
and a working version is available it can be merged.
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
@BiocondaBot please add labelcommand.@bioconda/corein a comment.Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update@BiocondaBot please add labelplease review & mergelabel.@BiocondaBot please fetch artifactsYou can use this to test packages locally.
For members of the Bioconda project, the following command is also available:
@BiocondaBot please mergeSomeone must approve a PR first!
This reduces CI build time by reusing built artifacts.
Also, the bot watches for comments from non-members that include
@bioconda/<team>and will automatically re-post them to notify the addressed<team>.