New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new recipe selenzy_wrapper v0.0.4 #31359
Conversation
Artifacts built on CircleCI are ready for inspection: Package(s)
You may also use
Container image(s)
|
Hello @kenza12, are you sure you need to restrict biopython to =1.77 only? |
Hello @telatin , I just update the recipe and added a new restriction for biopython >1.70,<=1.77 , I also added some tests but it failed for memory issues. Is there a limit for memory usage in bioconda ? If yes, is it possible to increase it ? Thanks for your work. |
Not that I'm aware, I usually put the more extensive tests on the repository CI and leave the bare minimum in conda to just check that the program runs / has the correct version. Is that a possibility? |
Hi @telatin , Thanks for your feedback. I don’t think it’s a problem about checking the program version. It doesn’t need so much resources to do that. And I got this error in the test session :
I see that bioconda use Linux Medium resources (2 CPU, 7.5 GB RAM), is that set automatically ? I don’t know if it needs to be rerun with larger resources maybe ? I’m a novice in bioconda and all CircleCI tests. Thanks for your help. Best wishes. |
Hi @telatin , @bioconda/core , Do you have any update about my issue please ? Thanks for your time. |
recipes/selenzy_wrapper/run_test.sh
Outdated
|
||
echo -e "\n\n*** TEST ***\n\n" | ||
python -m selenzy_wrapper --help | ||
pytest -v |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't run your full tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, is there no executable installed for this? Typically python packages would be executed like selenzy --help
or something like that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dpryan79 ,
Thanks for your reply.
I tried to run only one test but it always returns the same memory error. Finally, we decided not to run tests and to only check the imports and the help command line: python -m selenzy_wrapper --help
.
We don't have an executable selenzy --help
, we execute the package with this command python -m selenzy_wrapper --help
.
Thank your for your work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe in a future release adding a script to be invoked will make the tool more handy :)
Artifacts built on CircleCI are ready for inspection: Package(s)
You may also use
Container image(s)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests issue bypassed
Describe your pull request here
Add recipe for selenzy_wrapper 0.0.4: Python wrapper of selenzy tool
https://github.com/brsynth/selenzy-wrapper/
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
@BiocondaBot please add label
command.@bioconda/core
in a comment.Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update
@BiocondaBot please add label
please review & merge
label.@BiocondaBot please fetch artifacts
You can use this to test packages locally.
For members of the Bioconda project, the following command is also available:
@BiocondaBot please merge
Someone must approve a PR first!
This reduces CI build time by reusing built artifacts.
Also, the bot watches for comments from non-members that include
@bioconda/<team>
and will automatically re-post them to notify the addressed<team>
.