Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new recipe selenzy_wrapper v0.0.4 #31359

Merged
merged 6 commits into from Dec 1, 2021

Conversation

kenza12
Copy link
Contributor

@kenza12 kenza12 commented Nov 3, 2021

Describe your pull request here

Add recipe for selenzy_wrapper 0.0.4: Python wrapper of selenzy tool

https://github.com/brsynth/selenzy-wrapper/

Please read the guidelines for Bioconda recipes before opening a pull request (PR).

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.
Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

For members of the Bioconda project, the following command is also available:

@BiocondaBot please merge Upload built packages/containers and merge a PR.
Someone must approve a PR first!
This reduces CI build time by reusing built artifacts.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@BiocondaBot
Copy link
Collaborator

Artifacts built on CircleCI are ready for inspection:

Package(s)
Arch Package Repodata
noarch selenzy_wrapper-0.0.4-pyhdfd78af_0.tar.bz2 repodata.json

You may also use conda to install these:

  • For packages on noarch:
conda install -c https://174299-42372094-gh.circle-artifacts.com/0/tmp/artifacts/packages <package name>

Container image(s)
Package Tag Install with docker
selenzy_wrapper 0.0.4--pyhdfd78af_0
showcurl -L "https://174299-42372094-gh.circle-artifacts.com/0/tmp/artifacts/images/selenzy_wrapper%3A0.0.4--pyhdfd78af_0.tar.gz" | gzip -dc | docker load

@telatin
Copy link
Member

telatin commented Nov 3, 2021

Hello @kenza12, are you sure you need to restrict biopython to =1.77 only?

@kenza12
Copy link
Contributor Author

kenza12 commented Nov 17, 2021

Hello @telatin , I just update the recipe and added a new restriction for biopython >1.70,<=1.77 , I also added some tests but it failed for memory issues. Is there a limit for memory usage in bioconda ? If yes, is it possible to increase it ? Thanks for your work.

@telatin
Copy link
Member

telatin commented Nov 19, 2021

Hello @telatin , I just update the recipe and added a new restriction for biopython >1.70,<=1.77 , I also added some tests but it failed for memory issues. Is there a limit for memory usage in bioconda ? If yes, is it possible to increase it ? Thanks for your work.

Not that I'm aware, I usually put the more extensive tests on the repository CI and leave the bare minimum in conda to just check that the program runs / has the correct version. Is that a possibility?

@kenza12
Copy link
Contributor Author

kenza12 commented Nov 22, 2021

Hello @telatin , I just update the recipe and added a new restriction for biopython >1.70,<=1.77 , I also added some tests but it failed for memory issues. Is there a limit for memory usage in bioconda ? If yes, is it possible to increase it ? Thanks for your work.

Not that I'm aware, I usually put the more extensive tests on the repository CI and leave the bare minimum in conda to just check that the program runs / has the correct version. Is that a possibility?

Hi @telatin ,

Thanks for your feedback. I don’t think it’s a problem about checking the program version. It doesn’t need so much resources to do that.

And I got this error in the test session :

17:59:59 BIOCONDA INFO (OUT) OSError: [Errno 12] Cannot allocate memory
18:00:13 BIOCONDA ERROR COMMAND FAILED (exited with 1): docker run -t --net host --rm -v /tmp/tmpnu7niyow/build_script.bash:/opt/build_script.bash -v /home/circleci/project/miniconda/conda-bld/:/opt/host-conda-bld -v /home/circleci/project/recipes/selenzy_wrapper:/opt/recipe -e LANG=en_US.UTF-8 -e HOST_USER_ID=1001 quay.io/bioconda/bioconda-utils-build-env-cos7:0.17.8 /bin/bash /opt/build_script.bash

18:00:13 BIOCONDA ERROR BUILD FAILED recipes/selenzy_wrapper
18:00:13 BIOCONDA INFO (COMMAND) conda build purge
18:00:14 BIOCONDA ERROR BUILD SUMMARY: of 1 recipes, 1 failed and 0 were skipped. Details of recipes and environments follow.
18:00:14 BIOCONDA ERROR BUILD SUMMARY: FAILED recipe recipes/selenzy_wrapper

Exited with code exit status 1

I see that bioconda use Linux Medium resources (2 CPU, 7.5 GB RAM), is that set automatically ? I don’t know if it needs to be rerun with larger resources maybe ? I’m a novice in bioconda and all CircleCI tests.

Thanks for your help.

Best wishes.

@kenza12
Copy link
Contributor Author

kenza12 commented Nov 29, 2021

Hi @telatin , @bioconda/core ,

Do you have any update about my issue please ?

Thanks for your time.

@BiocondaBot
Copy link
Collaborator

Reposting for @kenza12 to enable pings (courtesy of the BiocondaBot):

Hi @telatin , @bioconda/core ,

Do you have any update about my issue please ?

Thanks for your time.


echo -e "\n\n*** TEST ***\n\n"
python -m selenzy_wrapper --help
pytest -v
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't run your full tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, is there no executable installed for this? Typically python packages would be executed like selenzy --help or something like that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dpryan79 ,

Thanks for your reply.

I tried to run only one test but it always returns the same memory error. Finally, we decided not to run tests and to only check the imports and the help command line: python -m selenzy_wrapper --help .
We don't have an executable selenzy --help , we execute the package with this command python -m selenzy_wrapper --help .

Thank your for your work.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe in a future release adding a script to be invoked will make the tool more handy :)

@BiocondaBot
Copy link
Collaborator

Artifacts built on CircleCI are ready for inspection:

Package(s)
Arch Package Repodata
noarch selenzy_wrapper-0.0.6-pyhdfd78af_0.tar.bz2 repodata.json

You may also use conda to install these:

  • For packages on noarch:
conda install -c https://177362-42372094-gh.circle-artifacts.com/0/tmp/artifacts/packages <package name>

Container image(s)
Package Tag Install with docker
selenzy_wrapper 0.0.6--pyhdfd78af_0
showcurl -L "https://177362-42372094-gh.circle-artifacts.com/0/tmp/artifacts/images/selenzy_wrapper%3A0.0.6--pyhdfd78af_0.tar.gz" | gzip -dc | docker load

Copy link
Member

@telatin telatin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests issue bypassed

@telatin telatin merged commit 8b7794d into bioconda:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants