-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add perl-bio-searchio-hmmer #33805
Add perl-bio-searchio-hmmer #33805
Conversation
This is needed for Bio::Index objects and classes that descend from it for the creation of index files.
@bioconda/core, when a PR touches multiple packages, why doesn't the package builder use the newly built ones when building the remaining packages? It's not reasonable to have to wait for each change to hit the archive before submitting the next one. There's an issue with a missing dependency in |
Reposting for @0xaf1f to enable pings (courtesy of the BiocondaBot):
There's an issue with a missing dependency in |
Due to inadequacies of the builder here, I'm forced to make this |
2928eff
to
db7fa21
Compare
This module was split out of the main bioperl distribution in version 1.7.3 (https://metacpan.org/dist/BioPerl/changes), but is still needed by Prokka (bioconda#33356).
Now that Bio::SearchIO::hmmer is packaged, we can use it as part of the latest bioperl distribution and there's no longer a need for this pinning. This reverts the workaround a32603c in favor of resolving the underlying problem.
db7fa21
to
bf5a3f3
Compare
@dpryan79 I added the missing dependency on When
instead of the freshly built from just a few minutes prior
which results in this subtle test failure:
|
bf5a3f3
to
fca629d
Compare
@BiocondaBot please update |
I meant to use the program 'true', but yaml interpreted it as a bool without the quotes.
so it's a general conda solver problem to not pull in the latest build of a package? Or is it channel priority not preferring local over bioconda/conda-forge? |
It looks like the mulled-build correctly picks up the new local packages, but the original build doesn't. Do you know why the two procedures behave differently? |
@BiocondaBot please add label. I'm still curious about why the regular build and mulled build don't resolve dependencies the same way. |
@0xaf1f The classic conda solver doesn't prioritize the most recent build, or even the most recent version. This has caused a LOT of headaches. Starting in conda 4.12 there's the option to use the mamba solver instead, which will try to use the highest build number and version, which should generally do more what people expect. |
@BiocondaBot please merge |
I will attempt to upload artifacts and merge this PR. This may take some time, please have patience. |
Ah, got it. Many thanks for getting this working! |
Bio::SearchIO::hmmer was formerly part of the core bioperl distribution until version 1.7.3 when it and a bunch of other components were split out into separate development repositories (thanks @rpetit3 for digging this up), so later bioperl packages here caused problems for the prokka package (#33356), which uses this component.
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
@BiocondaBot please add label
command.@bioconda/core
in a comment.Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update
@BiocondaBot please add label
please review & merge
label.@BiocondaBot please fetch artifacts
You can use this to test packages locally.
For members of the Bioconda project, the following command is also available:
@BiocondaBot please merge
Someone must approve a PR first!
This reduces CI build time by reusing built artifacts.
Also, the bot watches for comments from non-members that include
@bioconda/<team>
and will automatically re-post them to notify the addressed<team>
.