Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bioperl-core: add missing depends on perl-db_file #33806

Closed

Conversation

0xaf1f
Copy link
Contributor

@0xaf1f 0xaf1f commented Mar 20, 2022

The Bio::Index module needs perl-db_file to enable the creation of index files. perl-bio-searchio-hmmer, which I'm trying to add in #33805, indirectly uses this functionality via the parent class here, which made tracing the test failure I saw while testing that package really time consuming. it's not the only module to do so (e.g. Bio::AlignIO::stockholm also inherits from this class), and the dependency really belongs here because it's the interface defined here in bioperl-core that made the decision to go with perl-db_file, not anything that searchio-hmmer has any part in.


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.
Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

For members of the Bioconda project, the following command is also available:

@BiocondaBot please merge Upload built packages/containers and merge a PR.
Someone must approve a PR first!
This reduces CI build time by reusing built artifacts.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

This is needed for Bio::Index objects and classes that descend
from it for the creation of index files.
@0xaf1f 0xaf1f force-pushed the bioperl-core-add-missing-depends branch from 05f40cb to 4f80799 Compare March 20, 2022 09:08
@0xaf1f
Copy link
Contributor Author

0xaf1f commented Mar 20, 2022

@BiocondaBot please add label

@BiocondaBot BiocondaBot added the please review & merge set to ask for merge label Mar 20, 2022
@0xaf1f
Copy link
Contributor Author

0xaf1f commented Mar 21, 2022

Looks like the comprehensive PR #33805 will work out after all.

@0xaf1f 0xaf1f closed this Mar 21, 2022
@0xaf1f
Copy link
Contributor Author

0xaf1f commented Mar 21, 2022

@BiocondaBot please remove label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please review & merge set to ask for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants