-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SuSiEx with a patch to make its Makefile portable to Apple Clang. #44131
base: master
Are you sure you want to change the base?
Conversation
acf6b1b
to
4240f13
Compare
8822011
to
ec63d9a
Compare
Hi @pettyalex! Please have a look at the KB from our conda-forge friends regarding your OpenMP question: https://conda-forge.org/docs/maintainer/knowledge_base.html#openmp |
Co-authored-by: Mervin Fansler <mmfansler@gmail.com>
Whoops, I lost track of this one. I'd love to get it in. |
@BiocondaBot please add label |
@BiocondaBot please update |
mkdir -p $PREFIX/bin | ||
|
||
pushd src | ||
make |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make | |
make -j ${CPU_COUNT} |
+ CXXFLAGS+=-fopenmp | ||
+ LDLIBS+=-fopenmp | ||
+else | ||
+ CXXFLAGS=-fopenmp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this overwrites CXXFLAGS ? The earlier set -O3 -Wall -Wextra
will be lost
This adds SuSiEx, https://github.com/getian107/SuSiEx, a fine-mapping tool.
I could use a hand understanding if this recipe needs openMP libraries in the
host
andrun
section, it seems like other recipes don't have that but the binaries that this produces are dynamically linked againstlibomp.dylib
on Mac andlibgomp
on Linux.Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add label
command.@bioconda/core
in a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports
(see here for the rationale and comprehensive explanation).Add a
run_exports
section like this:with
...
being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}
while replacing
"myrecipe"
with eithername
if aname|lower
variable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update
@BiocondaBot please add label
please review & merge
label.@BiocondaBot please fetch artifacts
You can use this to test packages locally.
Note that the
@BiocondaBot please merge
command is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>
and will automatically re-post them to notify the addressed<team>
.