Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove Github workflows which have been moved to bioconda-containers #951

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

martin-g
Copy link
Contributor

See bioconda/bioconda-containers#65

Remove build-image.yml and the Docker images pushing in release-please.yml

@martin-g martin-g changed the title Remove Github workflows which have been moved to bioconda-containers ci: Remove Github workflows which have been moved to bioconda-containers Jan 11, 2024
@martin-g martin-g force-pushed the remove-build-env-gh-workflow branch 5 times, most recently from d39c049 to a5d4b62 Compare January 11, 2024 12:22
See bioconda/bioconda-containers#65

Remove `build-image.yml` and the Docker images pushing in `release-please.yml`

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Depends-on: bioconda/bioconda-containers#66

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@martin-g martin-g marked this pull request as draft January 12, 2024 12:21
@martin-g martin-g closed this Jan 22, 2024
@martin-g martin-g reopened this Jan 22, 2024
@martin-g martin-g marked this pull request as ready for review January 22, 2024 13:59
@martin-g
Copy link
Contributor Author

All seems to be good! The PR is ready for review!

Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful!

@bgruening
Copy link
Member

@daler also ok for you?

@daler
Copy link
Member

daler commented Jan 22, 2024

Looks good, but I think we should hold off actually merging this. Over on bioconda-containers things are still being fixed (bioconda/bioconda-containers#69, bioconda/bioconda-containers#68) so if we merge this then we'll have no working way of creating images.

@daler daler mentioned this pull request Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants