Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix font size for rare taxa list #181

Merged
merged 2 commits into from
Dec 15, 2015

Conversation

EmbrietteH
Copy link
Contributor

This PR adds the previous code change done by Luke, and in addition, further changes the font size from small to footnotesize to ensure participant pdfs are a single page.

@mortonjt
Copy link
Contributor

mortonjt commented Dec 6, 2015

This is interesting. Looks like the build took too long :/

@mortonjt
Copy link
Contributor

mortonjt commented Dec 6, 2015

Looking over this post, I'd try adding travis_wait at the beginning of the last line in the .travis.yml

@EmbrietteH
Copy link
Contributor Author

The build has completed successfully now (thanks @mortonjt ). @mortonjt @squirrelo @josenavas can I get a review?

@squirrelo
Copy link
Contributor

Code looks fine. Is there a before & after render screenshot?

@EmbrietteH
Copy link
Contributor Author

Before and after shots (in reverse order). Before: 2 pages due to the rare taxa list being too long and pushing down the PCoA plots onto the second page. After: everything on a single page.

Note that the number of rare taxa is slightly different as the before shot was taken from results produced after rounds1-21 and the after shots was taken from results produced after rounds 1-22.

after
before

@squirrelo
Copy link
Contributor

Looks good to me, 👍

josenavas added a commit that referenced this pull request Dec 15, 2015
@josenavas josenavas merged commit 8aaddf0 into biocore:master Dec 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants