Center biplot #27
Center biplot #27
Conversation
|
|
||
| # Sample Loadings | ||
| sample_loading = pd.DataFrame(opt.sample_weights, index=table.index) | ||
| sample_loading = sample_loading.rename(columns=rename_cols) | ||
| sample_loading -= sample_loading.mean(axis=0) |
There was a problem hiding this comment.
This doesn't have to be resolved now, but for the lucky future developer - it looks like there is some redundancy here compared to _method.py. May want to redefine some functions to avoid copy-pasta fixes like this.
There was a problem hiding this comment.
definitely. need to merge between them.
There was a problem hiding this comment.
Another note for a future developer, there will eventually need to have unittests to test the contents of feature loadings and sample loadings -- this will become more important for regression testing to catch future bugs.
There was a problem hiding this comment.
These notes/suggestion will be lost - what about creating specific issues in the repo and adding a full description of what needs to be done + pointing here?
|
@cameronmartino - don't forget to include a snapshot of the emperor plot before we merge, so that we can take a note that this issue has been resolved. |
|
@mortonjt good point. After: |
|
Hmm - can't seem to see the after image ... |
|
Ok - looks good. @cameronmartino don't forget to update the changelog and then I can merge this in. |
resolves issue #26