adding i5_i7_index #666
Merged
adding i5_i7_index #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josenavas
approved these changes
Apr 17, 2017
|
Should there be any data access changes? |
josenavas
approved these changes
Apr 17, 2017
wasade
reviewed
Apr 17, 2017
|
|
||
| CREATE TABLE pm.shotgun_index_tech ( | ||
| shotgun_index_tech_id bigserial NOT NULL, | ||
| name varchar(100) , |
There was a problem hiding this comment.
Honestly, cause that was the default in dbSchema and didn't catch it. However, this is just the name of the tech, which in general is like 20 chars ...
| @@ -236,17 +244,17 @@ CREATE TABLE pm.water_lot ( | |||
| CONSTRAINT uq_water_lot_name UNIQUE ( name ) | |||
| ); | |||
|
|
|||
| CREATE TYPE target_region AS ENUM ('16S', '18S', 'ITS'); | |||
| CREATE TYPE target_subfragment AS ENUM ('V4'); | |||
| CREATE TYPE pm.target_region AS ENUM ('16S', '18S', 'ITS'); | |||
There was a problem hiding this comment.
Should this differentiate ITS1, ITS2, overhanging (e.g., sequencing 3' of 18S into ITS1)? Perhaps as subfragment?
There was a problem hiding this comment.
Good question, I just fixed the pm part of this but I can add more ... @josenavas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.