Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #770, date keyword from json #771

Closed
wants to merge 5 commits into from
Closed

Conversation

schferbe
Copy link
Contributor

No description provided.

@wasade
Copy link
Member

wasade commented Mar 27, 2018

Thanks, @schferbe. It looks like there are real failures here, can that be fixed?

@coveralls
Copy link

coveralls commented Mar 27, 2018

Coverage Status

Coverage increased (+0.009%) to 86.447% when pulling bca1e02 on schferbe:master into 619e591 on biocore:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling a9cadeb on schferbe:master into 43b4217 on biocore:master.

@schferbe
Copy link
Contributor Author

schferbe commented Mar 27, 2018

@wasade I think the failures I caused should be fixed now...

@wasade
Copy link
Member

wasade commented Mar 27, 2018

Thanks. It looks like the current failures are due to flux in flake8 and sphinx which are out of context for this PR. If you're able to fix those (either by restricting the versions, or addressing the errors) that would be fantastic, but I understand if you'd prefer not too. I cannot merge until they are addressed and unfortunately not something like to get to today.

Actually, one more request, would it be possible to add a mention into the changelog?

@schferbe
Copy link
Contributor Author

It wasn't my intention to get that deeply involved into your project. I'd prefer you fixing the remaining issues. Thank you.

I will add something to the changelog...

@wasade
Copy link
Member

wasade commented Sep 10, 2018

Hi @schferbe, sorry for the delay on this. The dateutil library as specified isn't compatible with the (wide) range of numpy versions we support. Is it possible to bound the version, or preferably to perform the parsing using the standard library to avoid adding a dependency?

@wasade
Copy link
Member

wasade commented Aug 27, 2019

Closing as there doesn't seem to have been progress finalizing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants