New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix travis #189
Fix travis #189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good except one comment
if method == 'nonzerospearman': | ||
sample_nonzero = sp.stats.rankdata(sample_nonzero) | ||
label_nonzero = sp.stats.rankdata(label_nonzero) | ||
sample_nonzero = sample_nonzero - np.mean(sample_nonzero) | ||
label_nonzero = label_nonzero - np.mean(label_nonzero) | ||
tstat[i] = np.dot(sample_nonzero, label_nonzero) | ||
t[i] = np.abs(tstat[i]) | ||
if np.std(sample_nonzero) == 0: | ||
continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can u combine it with the if on 275 line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
less convenient since sample_nonzero is modified after the first if and before this if... and i think also will be less clear to understand if joined.
Fix more travis warnings and pep8 stuff