Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dbbact metadata #209

Merged
merged 8 commits into from
Jul 11, 2020
Merged

Dbbact metadata #209

merged 8 commits into from
Jul 11, 2020

Conversation

amnona
Copy link
Collaborator

@amnona amnona commented Jul 10, 2020

Make database interface compatible with the new database metadata structure:

  • convert Experiment.databases to defaultdict(dict). i.e. for dbbact data is stored in exp.databases['dbbact']
  • add minimal version support to database config file and test it

RNAer
RNAer reviewed Jul 11, 2020
View reviewed changes
calour/amplicon_experiment.py Outdated

See Also
--------
Experiment
'''
def __init__(self, *args, databases=('dbbact',), **kwargs):
super().__init__(*args, databases=('dbbact',), **kwargs)
def __init__(self, *args, databases=('dbbact'), **kwargs):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need the comma

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed :)

@amnona
Copy link
Collaborator Author

amnona commented Jul 11, 2020

ok ready for merge retry

@RNAer RNAer merged commit 556bdf9 into biocore:master Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RNAer RNAer RNAer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amnona @RNAer