New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command line and QIIME2 -- refactoring #16

Merged

gwarmstrong merged 24 commits into master from command-line

Aug 28, 2019

Collaborator

cameronmartino commented Jul 23, 2019

No description provided.

cameronmartino and others added 3 commits

June 14, 2019 15:42


          update feactorization nomenclature


          fix pep

dbe897f


          update all

b2400c0

gwarmstrong reviewed

View reviewed changes

gemelli/factorization.py Outdated Show resolved Hide resolved

gwarmstrong reviewed

View reviewed changes

gemelli/factorization.py Outdated Show resolved Hide resolved

gwarmstrong reviewed

View reviewed changes

gemelli/factorization.py Show resolved Hide resolved

gwarmstrong reviewed

View reviewed changes

gemelli/preprocessing.py Show resolved Hide resolved

gwarmstrong reviewed

View reviewed changes

gemelli/q2/_format.py Outdated Show resolved Hide resolved

gwarmstrong reviewed

View reviewed changes

gemelli/q2/_format.py Outdated Show resolved Hide resolved

gwarmstrong reviewed

View reviewed changes

gemelli/ctf.py Outdated Show resolved Hide resolved

gwarmstrong reviewed

View reviewed changes

gemelli/ctf.py Show resolved Hide resolved

gwarmstrong reviewed

View reviewed changes

gemelli/tests/test_tenals.py Show resolved Hide resolved

gwarmstrong reviewed

View reviewed changes

gemelli/tests/test_tenals.py Show resolved Hide resolved

gwarmstrong reviewed

View reviewed changes

setup.py Show resolved Hide resolved

gwarmstrong reviewed

View reviewed changes

setup.py Show resolved Hide resolved

gwarmstrong reviewed

View reviewed changes

gemelli/tests/test_preprocessing.py Show resolved Hide resolved

gwarmstrong reviewed

View reviewed changes

gemelli/tests/test_log_ratios.py Outdated Show resolved Hide resolved

gwarmstrong reviewed

View reviewed changes

gemelli/tests/test_log_ratios.py Outdated Show resolved Hide resolved

gwarmstrong reviewed

View reviewed changes

gemelli/log_ratios.py Outdated Show resolved Hide resolved

gwarmstrong reviewed

View reviewed changes

gemelli/preprocessing.py Outdated Show resolved Hide resolved

gwarmstrong reviewed

View reviewed changes

gemelli/preprocessing.py Show resolved Hide resolved

gwarmstrong reviewed

View reviewed changes

gemelli/q2/tests/test_transformer.py Outdated Show resolved Hide resolved

gwarmstrong reviewed

View reviewed changes

Member

gwarmstrong left a comment

Looks pretty good, left some comments on the diff

cameronmartino added 7 commits

August 20, 2019 16:10


          fix log-ratio docstring

74efa3a


          remove x in tensorx to tensor

95a4421


          remove random comment

cb06e63


          meaned vs. sum doc string fix


          n_comp -> comp_columns

3cd4efa


          fix if statement check for floats

0dc7461


          fix assertIsInstance test

cd2f3cb

cameronmartino added 5 commits

August 27, 2019 10:01


          two different context managers in test

73d3041


          remove un-used partially untested log-ratio code

59a0f90


          fix random init and value-error

5a26bd6


          fix expected after new random init

a285942


          remove recpie breaking command

07e3726

cameronmartino mentioned this pull request

A more generic method for pre-install checks in setup.py #18

Open

cameronmartino added 8 commits

August 27, 2019 15:19


          update README

71ed4f4


          add tutorial data and docs

e987811


          update exp. files

6859ae8


          update readme for new code

f7459b3


          update default iter

2da528c


          minor fixes in the output -- easier to follow for visuals in q2

a80e0d1


          update eig sort

5911b51


          final touchup

5f8f4f2

Collaborator Author

cameronmartino commented Aug 28, 2019

@gwarmstrong This should be good to merge now.

cameronmartino mentioned this pull request

42 is an odd default value for random_state. Change to None. #20

Open


          ver bump

38be609

gwarmstrong merged commit 8282216 into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment