New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Seedset protoclass #19
Conversation
@qiyunzhu ready for a review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! @sjanssen2 The rationale is very clear. So the order of seeds is not important. The program just picks random one each time until all seeds are gone. Is that right?
I cannot say that I understand this PR fully, but the code looks good! |
@tkosciol Thank you! The code is to let the prototype selection function take a pre-defined set of "seeds", which are guaranteed to be selected as prototypes. The remaining prototypes will be calculated based on them. |
Hi @qiyunzhu I never replied to your question. You are right: elements of the seedset are made prototypes in a random ordering until all are "consumed". |
Adressing issue #16 : adding seedset functionality to last outstanding prototype function 'protoclass'