Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seedset protoclass #19

Merged
merged 6 commits into from Jul 24, 2017
Merged

Seedset protoclass #19

merged 6 commits into from Jul 24, 2017

Conversation

sjanssen2
Copy link
Collaborator

Adressing issue #16 : adding seedset functionality to last outstanding prototype function 'protoclass'

@coveralls
Copy link

coveralls commented Jul 18, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 57a45a0 on sjanssen2:seedset_protoclass into ad1a207 on biocore:master.

@sjanssen2
Copy link
Collaborator Author

@qiyunzhu ready for a review

Copy link
Collaborator

@qiyunzhu qiyunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! @sjanssen2 The rationale is very clear. So the order of seeds is not important. The program just picks random one each time until all seeds are gone. Is that right?

@tkosciol
Copy link
Member

I cannot say that I understand this PR fully, but the code looks good!
@qiyunzhu I'm not able to merge, because I'm not a member of this project.

@qiyunzhu
Copy link
Collaborator

@tkosciol Thank you! The code is to let the prototype selection function take a pre-defined set of "seeds", which are guaranteed to be selected as prototypes. The remaining prototypes will be calculated based on them.

@qiyunzhu qiyunzhu merged commit 2c30853 into biocore:master Jul 24, 2017
@sjanssen2
Copy link
Collaborator Author

Hi @qiyunzhu I never replied to your question. You are right: elements of the seedset are made prototypes in a random ordering until all are "consumed".
Since at least |seedset| elements will be returned as prototypes (even if the user set num_prototypes to a smaller number) the ordering should not matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants