Skip to content
This repository has been archived by the owner on Jul 29, 2020. It is now read-only.

DO NOT MERGE #121

Closed
wants to merge 3 commits into from
Closed

DO NOT MERGE #121

wants to merge 3 commits into from

Conversation

sjanssen2
Copy link
Collaborator

No description provided.

Merge branch 'master' of https://github.com/biocore/labadmin

Conflicts:
	knimin/tests/test_auth_handlers.py
	knimin/tests/test_projects_summary.py
@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.433% when pulling 16cd56b on sjanssen2:coverall into cee7268 on biocore:master.

@sjanssen2
Copy link
Collaborator Author

@wasade @josenavas I don't understand how the coverage is computed. How can the file knimin/lib/string_converter.py have a coverage of 38.89% after I commented all tests out in the according knimin/lib/tests/test_string_converter.py ?

@sjanssen2
Copy link
Collaborator Author

I also don't understand why coverage is not 100%, because it looks to me that all functions are triggered more than once.

@wasade
Copy link
Member

wasade commented Sep 23, 2016

@sjanssen2
Copy link
Collaborator Author

Oh I see. I commented out all those lines, because I don't understand why the coverage is not 100% for this module. Might it be the case, that the according unit tests in knimin/lib/tests/test_string_converter.py are never executed? If so, is that a bug in some config file?

@wasade
Copy link
Member

wasade commented Sep 23, 2016

not sure of a config file which would effect this, only one i can think that might is here. how does coverage look when you run locally? if you run the tests directly, do they actually run?

@sjanssen2
Copy link
Collaborator Author

sjanssen2 commented Sep 23, 2016

I found the problem, the executable bit for this test file was set, thus nose did not want to run these tests :-)
Ping @qiyunzhu because I bugged him with this problem too.

@wasade
Copy link
Member

wasade commented Sep 23, 2016

i love and hate nose...

@wasade
Copy link
Member

wasade commented Sep 23, 2016

good find btw :)

@sjanssen2 sjanssen2 closed this Sep 23, 2016
@sjanssen2 sjanssen2 deleted the coverall branch September 23, 2016 22:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants