Prep for ui email verification and legacy acct support #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wasade
reviewed
Apr 23, 2020
| @@ -89,9 +89,9 @@ def claim_legacy_acct(token_info): | |||
| t.commit() | |||
|
|
|||
| if acct is None: | |||
| return jsonify(code=404, message=ACCT_NOT_FOUND_MSG), 404 | |||
| return jsonify([]), 200 | |||
There was a problem hiding this comment.
Just to make sure, this is supposed to switch from 404 -> 200?
There was a problem hiding this comment.
@wasade Thanks for the check, and yes, it is intentional. I agree it feels a bit odd, but basically the change in messaging is from "I looked for a particular account and failed to find it (404)" to "I successfully searched for accounts and here is a list of all the ones I found (200)", even when when the list is empty because I found no accounts. This matches the idiom of find_accounts_for_login, which also considers success to mean "I searched successfully", not necessarily "I found something" :)
|
Thanks!! |
AmandaBirmingham
deleted the
prep_for_UI_email_verification_and_legacy_acct_support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing the client changes for requiring email verification and letting users claim legacy accounts, I ran across a couple of things that I wanted/needed to change. First of all, although AuthRocket's documentation said they will send back a claim named 'email_verification', actually they send back one called 'email_verified' ... ok. Second, in the interface code it is convenient to have the interface for finding a legacy account (by email) be of the same structure as the interface for finding an account by login info; therefore, I modified POST /accounts/legacies to return an array--empty if it found (and claimed) no legacy account, filled with a single account if it did find and claim one. Just as for
find_accounts_for_login, the api structure supports returning more than one account, but the underlying code inimplementation.pyis not actually capable of returning more than one account at a time.