St dh admin toolbar #183
St dh admin toolbar #183
Conversation
…_toolbar # Conflicts: # microsetta_private_api/example/client.yaml # microsetta_private_api/example/client_impl.py
|
Note: Don't merge this until the user account info editing goes in, otherwise parts of the diff won't make much sense since it was spun out of that branch. |
| if do_return: | ||
| return email_diagnostics | ||
|
|
||
| accounts = [{"email": acct['email'], "account_id": acct['id']} |
There was a problem hiding this comment.
I'm not entirely sold on the necessity of doing this ... jinja templates can take objects, so perhaps we could just pass in the email_diagnostics['accounts'] value to the template and access the fields in it that are needed directly from the template?
There was a problem hiding this comment.
Yeah... But the admin diagnostics objects are enormous and don't have a schema specified. I can push the diagnostics object to jinja if you really want, but I was worried I would stupidly leave a comment like <!-- {{account}} --> in the jinja2 and leave web pages showing commented out admin diagnostics in them. I just found it easier to figure out what fields I actually needed on the python side than the jinja side.
…_toolbar # Conflicts: # microsetta_private_api/example/client_impl.py
| {% set show_breadcrumbs = True %} | ||
| {% set disable_bootstrap = True %} | ||
| {% block head %} | ||
| <!-- Argh, Bootstrap 3 and 4 don't mix. So the header and footer look slightly different on this page --> |
There was a problem hiding this comment.
This is resolved in #202 as bootstrap 3 is no longer needed
| </div> | ||
| </div> | ||
|
|
||
| <!-- These should really be in the head, but don't easily work there. | ||
| Probably needs a document.load handler or something? --> |
|
|
||
| <!-- jquery must be enabled before bootstrap for collapsible functionality --> | ||
| {% if enable_jquery %} | ||
| <script src="/static/vendor/js/jquery-3.4.1.min.js"></script> |
There was a problem hiding this comment.
...we're using multiple versions of jquery. that's awkward, I'm going to see if I can clean that up...
…_toolbar # Conflicts: # microsetta_private_api/templates/sample.jinja2 # microsetta_private_api/templates/source.jinja2
Adds administrator functionality to the minimalInterface. For the most part, this is just a new home page and navbar that allows searching accounts by email address. But in order to get to that point, many of our pages had to be updated to extend sitebase.