No implicit form submission #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avascript function, and mismatched html tags
…ddition of call to this function from relevant jinja templates and vue_survey_form.js
wasade
approved these changes
Jun 15, 2020
…e-api into no_implicit_form_submission � Conflicts: � microsetta_private_api/static/input_util.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #189 Prevent survey submission when hitting enter in form (i.e., implicit submission).
Note that I have NOT prevented implicit submission on the admin email search form, because it has only one field (email input) and having the search happen when you hit return in that field is convenient, and because I figured admins could handle two ways to submit :)
However, I HAVE prevented implicit submission on the one-input-field form in source.jinja2 that retrieves samples in a kit when provided with a kit name, mostly because I was worried that end users would be confused if it acted differently than the other, more complicated forms. I would be interested on opinions from the team on whether to keep this approach or let all one-field forms (but not others) do implicit submission.