Allow Redirects On Login #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. This enables generation of links that send users/admins to specific pages via email or external tools. Added redirects.py utility for generating such links. This file can be used standalone to generate a link of your choice. Only GETs can use this set of operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added parameter to /authrocket_callback allowing redirect after login. This enables generation of links that send users/admins to specific pages via email or external tools. Added redirects.py utility for generating such links. This script can be used standalone to generate a link of your choice (note that its output is only useful for the server where you run it, dev/staging/production). Only GETs can use this set of operations
We will need to remember that any links we send out to end users form a loose contract with that user that we will not change our urls (or we will invalidate those links). Depending on our requirements, we can layer complexity onto this mechanism to allow signing of links with specific tokens, link expiration, etc.