WIP: Admin API Routes For Sending Emails #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sample_barcode, enforced that body must contain account_id to allow future searching of event log
…, rather than the external component specifying what email to send to. This ensures the email lookup based on the sample barcode is always in sync with the current database. Event log items are marked with consistent email and account_id. Templates now include a resolution_url that sends user to their sample information page
wasade
requested changes
Jul 6, 2020
microsetta_private_api/templates/email/incorrect_sample_type.jinja2
Outdated
Show resolved
Hide resolved
microsetta_private_api/templates/email/incorrect_sample_type.jinja2
Outdated
Show resolved
Hide resolved
microsetta_private_api/templates/email/incorrect_sample_type.jinja2
Outdated
Show resolved
Hide resolved
microsetta_private_api/templates/email/incorrect_sample_type.jinja2
Outdated
Show resolved
Hide resolved
microsetta_private_api/templates/email/incorrect_sample_type.plain
Outdated
Show resolved
Hide resolved
microsetta_private_api/templates/email/missing_sample_info.jinja2
Outdated
Show resolved
Hide resolved
microsetta_private_api/templates/email/missing_sample_info.jinja2
Outdated
Show resolved
Hide resolved
microsetta_private_api/templates/email/missing_sample_info.jinja2
Outdated
Show resolved
Hide resolved
… to reference the account's first_name and last_name fields
…eters are sent to jinja2
…_routes # Conflicts: # microsetta_private_api/admin/admin_impl.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new route at POST /api/admin/email that will send an email. At the moment, it supports two email templates, both filled in based on a sample_barcode. The breakdown of where template arguments come from, between the api side, and the admin tools remains a little bit fuzzy, but this should get us 80% of where we want to get to.
This builds on st_dh_event_log.
This feature requires end to end testing with real sending of emails before it goes live, and I'm not currently set up to do that.