-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Email Templates - User can't edit locked samples #247
Conversation
…heir samples directly
Sample locked override
Thanks! A proposed email for "sample-is-valid":
And I think "no-associated-source", I think the following:
@specsdom, these seem good? |
For the sample-is-valid email, I'm trying to think of how to reword this to be inclusive of studies where the samples are being banked (since saying a sample is in the processing queue could suggest that a sample will be processed soon), but it inevitably just sounds vague if we say "some samples will be banked and processed later" without being clear on which ones will be affected... which could be okay. If people really are curious, they could ask the help account. I know we discussed previously having two methods in place: One for when samples are received, but get banked, and another when a sample are actually being plated for processing. This adds some more complexity, but could we instead have two different templates that go out for "sample-is-valid" samples? Like what we suggested with the samples that have inconsistencies, there could be an additional menu drop-down that lets the technician choose which email to send out: One for samples that are actively being plated, and one for samples that are being banked (which would also change the workflow for technicians, as that would effectively mean samples should be re-scanned once they do get plated, so participants know that their sample is now processing). Alternatively, on the Microsetta public website, we wanted to have a page dedicated to active cohorts and specify processing times (looks like this right now). We could link to this page in the sample-is-valid email so users can be aware the status of studies and when we're processing samples from a specific study, then keep it simplified to just one email. Only problem is this page isn't up yet, but I could put something really simple together until Departures has it up.
Modified this a bit (asterisks signify bolded text)--when I list out the steps with instructions to participants, they usually have a much easier time understanding what to do. For the email templates for samples that are missing info or have inconsistencies: The ones currently being used should still be good. |
…m:biocore/microsetta-private-api into st_dh_sample_locked_email_template_change
Annoyingly that push brought over some other commits. This branch must have been created before the admin override piece was merged? |
Looks good! Guessing the .plain file for the sample-is-valid email is the correct one to check. Presumably then it'll be easier to link to the active cohorts page (once available) in this template instead so participants can check the processing status of their project? |
The .plain and .jinja2 templates are for supporting both plaintext and HTML email clients -- the content should be the same. |
Rewording in email templates since user can't currently edit their samples directly.