Split Primary/Vioscreen Surveys Into Separate IDs #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a new uuidv4 id, vioscreen ids remain unchanged
…een and primary survey rather than just pointing everything at primary survey
wasade
reviewed
Oct 21, 2020
|
I don't particularly need the old->new mapping afaik, if we're worried about data loss we should have snapshots from before the schema change. I did consider assigning the new IDs as some determined function of the old IDs, we could do that instead, but then we wouldn't have true uuidv4s anymore. The mapping is also (mostly) implicitly defined by looking at the ag_login_survey table -- anywhere a primary and vioscreen survey were taken for the same account and source either those two used to be the same ID or the surveys weren't taken until after the ID split. |
|
True -- very good point regarding the rolling backups. |
wasade
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that our database has primary and vioscreen surveys sharing IDs in a number of legacy accounts. This is frustrating since we need the ability to say what type a particular survey ID is, and saying both isn't part of our model. This PR is a schema change to fork the IDs- primary surveys are assigned a new UUID and tables that reference the survey ID are updated or forked as necessary.