Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account Summaries Backend #277

Merged
merged 5 commits into from Nov 16, 2020
Merged

Account Summaries Backend #277

merged 5 commits into from Nov 16, 2020

Conversation

dhakim87
Copy link
Collaborator

Supports displaying summaries of samples in accounts by email address for microsetta-admin

wasade
wasade requested changes Nov 13, 2020
View reviewed changes
Copy link
Member

@wasade wasade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add in a test of one or two "email addresses" from the test database, with and without a project restriction?

microsetta_private_api/admin/admin_impl.py Outdated Show resolved Hide resolved
microsetta_private_api/repo/sample_repo.py Show resolved Hide resolved
@dhakim87
Defaulted emails to empty list rather than None, added unit test exer…
c6e1553 
…cising new route with no project, a valid project, and an invalid project
@wasade wasade merged commit 3dacfb0 into master Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wasade wasade wasade requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dhakim87 @wasade