Fixes issue 57 and 58 (for merge after db migration) #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue 58 (Add description field to non-human sources)--note, this new field is actually named "source_description", not description, for consistency with existing yaml field naming
wasade
reviewed
Jan 28, 2020
| type: string | ||
| nullable: true # TODO: Dan Hakim, do you agree? |
There was a problem hiding this comment.
Just noting that it would be great if this TODO is resolved within this PR
This was referenced Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue 57 (Remove participant_name field in the consent info)
Fixes issue 58 (Add description field to non-human sources)--note, this new field is actually named "source_description", not description, for consistency with existing yaml field naming