Basic framework for testing flask server #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…It was honestly hard to find something we could pass :P
…n now has two working tests
wasade
requested changes
Jan 29, 2020
There was a problem hiding this comment.
Would it be possible to shift this under unittest.TestCase? An example can be found here:
https://github.com/qiime2/q2-emperor/blob/master/q2_emperor/tests/test_plot.py#L21
…nts and other projects in the qiime2 ecosystem
…e-api into st_dh_flask_testing
…set this field to null as no account will be associated with them
…of mock kits/samples. Working through the list of integration tests (yes, they all still fail)
…unt registration that checks for valid kit name then adds the new account
…ssociation and integration test: add_sample_from_kit
…e api, matching the database layer.
…reation of sources
… added sample info, and for associating/dissociating samples with surveys
…e at least some implementation
Now return empty 0 byte responses rather than the JSON of empty string, which is in fact two characters long Added test for sample+survey association Added mechanisms to return information about a survey template beyond just its ID
…able. Explicitly restricted fields written at DB layer with introduction of new SampleInfo class. Specified isoformat for datetime serialization/deserialization over json (unclear if this is true iso8601 or if relying on python isoformat may burn us later) Added integration test for editing sample information
This was
linked to
issues
Feb 7, 2020
Closed
…e current form. Its a hacky patch job because at the end of the day, we have NO LOCALIZATION: Every single question, every single response, in american and british, are exactly the same. We will need a better plan for doing localization in the future. It hooks in in too many places and the actual translation step will not be robust as it lacks context.
…, apparently get_samples_by_source didn't work because of missing parens??
…at least until someone decides otherwise
…t account to delete their surveys
…he api we set out for consent (but doesn't break it enough to throw errors and maybe it should?)
|
Thank you both for the extremely thorough reviews! It looks like we have a couple of action items for the next meetings and some new issues. The discussion items we should cover are:
|
This was referenced Feb 23, 2020
AmandaBirmingham
approved these changes
Feb 23, 2020
|
Ok, I have signed off on this PR :) |
wasade
approved these changes
Feb 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test_integration.py with the ability to modify the test database, run the server, and call the api methods. This will form the foundation for writing tests for issue #37 but separate pull requests will test and fix each checkbox of that issue