Issue 81 #83
Merged
Issue 81 #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t return animal/environment source_description field. Added to existing unit test to check source_description is returned
…ure PUT source is working
|
Per the slack conversation, it would be pleasant to be able to update a participants email but that is a future development item. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #81
Looks like I missed implementing the PUT Source functionality. Had to specify which fields they could edit, so I restricted them to just source_name and source_description for now. Not sure how much of a pain it would be to specify just these fields in the yaml and everything else readonly.
Also noticed the GET on source was never updated after we added the source_description fields, so we that's in now too.
Unit tests for both.