Library fields #1486
Merged
Library fields #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you pull upstream master here? |
|
Not sure we want to do that here. If we go based on plan that should happen in @josenavas' PR. What do you think? |
…nto library_fields
|
Got it. Is from ebi-improvements not from master. Done. |
|
👍 @ElDeveloper time for a quick review in here? It is really easy/fast. |
|
My bad, I meant from ebi-improvements not from master :L |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1484 should be merged first.
This hardcodes to "good" values:
Also removed some constants no needed anymore in test_ebi.py