Instrument model #1484
Merged
Instrument model #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is ready for review: @biocore/qiita-dev |
| "(instrumet model wasn't checked): %s" % ( | ||
| ', '.join(nvp))) | ||
| if nvim: | ||
| error_msgs.append("These samples have ado not have a valid " |
There was a problem hiding this comment.
ado -> do
reminded me of a song though ... 🎼
There was a problem hiding this comment.
oh and have is before the not.
|
I think this looks good overall, I would just suggest adding a note to the ChangeLog about this new required column for submissions to EBI. |
|
👍 once @ElDeveloper comments are addressed. There will be some merge conflicts with my PR, but it is way easier to solve them in my branch. |
|
Ready to go! |
Merged
|
👍 @ElDeveloper can you review/merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the instrument model field as a required field for EBI submission. Most of the changes are due to fixing tests. Notable changes: changed the template documentation page, and travis.yml to remove two lines and make it one (suggestion by @josenavas in previous request and found how to do it).