fix #388 #2024
Merged
fix #388 #2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot to mention that I also have code to deal with the current duplicated fields, following Gail's suggestions, so the patch shouldn't do anything in the real system. That code is being tested in the test environment and applied before deploying this patch. |
|
Tests are failing. Code looks good. It looks like all the python patch is dealing with SQL only - is it possible to write that code in pure SQL? If it is going to be a pain - fine as it is. |
|
Restarted tests, it was the random postgres error. I would prefer to leave the patch as is. |
|
👍 |
|
@antgonza it seems that there is a real error |
|
Yes, the error was that one of our tests was adding a duplicated column 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decided to add _check_duplicated_columns cause it avoids duplication of code, which is an internal method in the prep_template.py.