Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skbio.root_at_midpoint hits recursion limit on large trees #1227

Open
gregcaporaso opened this issue Dec 9, 2015 · 1 comment
Open

skbio.root_at_midpoint hits recursion limit on large trees #1227

gregcaporaso opened this issue Dec 9, 2015 · 1 comment

Comments

@gregcaporaso
Copy link
Contributor

This method hits the recursion limit on very large trees (I hit it on a tree with around 3m tips). We should fix this, or at least provide a more useful error message (current error is not useful to users: RecursionError: maximum recursion depth exceeded).

In the meantime, I work around this limitation by doing midpoint rooting with ete3 as follows:

from ete3 import Tree
t = Tree("combined-ssu-align/combined-ssu-align.bacteria.mask.tre", format=1)
t.set_outgroup(t.get_midpoint_outgroup())
t.write(outfile="combined-ssu-align/combined-ssu-align.bacteria.mask.mid-rooted.tre", format=1)

This issue was first noticed in connection with #1077.

@JTFouquier
Copy link
Contributor

Thanks @gregcaporaso for this! I was pretty lost. A better warning here would have be very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants