New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
six/future #691
Comments
Thanks @Jorge-C. Does this mean that |
I think that's the case, I am getting some errors when installing On (Oct-03-14|12:44), Greg Caporaso wrote:
|
Yeah, unfortunately yes. This was uncovered by this PR in QIIME (thanks @ekopylova!). And unfortunately we could have avoided it by pinning the future version b/c we mentioned this change in the future library when refactoring the IO back in August, but we missed taking action at that point. |
Ok, thanks. What do you guys think the solution is here generally moving forward? We can also get ourselves in trouble by being too restrictive with versions (because we can then end up with incompatible dependencies across packages). |
I agree with you, maybe it's better to avoid restricting the future version. We could create a small The main reason for this two step process is that making the changes to distinguish between text and bytes may take some time, so maybe you'd prefer to do a release faster. |
Quick follow up. Needed to get this working locally, so did:
and back to working install. |
:+:'1: that also worked for me. Yoshiki Vázquez-Baeza
|
We have a temporary fix in place for this now. Going to work on a better fix later today, but for the meantime #692 gets the dev version working again, so we can use travis. |
future 0.14+ has stopped bundling the six library that we used mainly to deal with StringIO compatibility.
A quick way forward is to either add six to our requirements or write a (tiny) module that has the functionality we were using.
But, the good course of action is to follow what the people taking care of the future package recommend. In fact, we have the same guideline in our documentation, but somehow it was hard to turn into reality.
In the meantime, we can restrict its version to < 0.13 too.
The text was updated successfully, but these errors were encountered: