Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation suite #101

Merged
merged 10 commits into from
Nov 15, 2022
Merged

Documentation suite #101

merged 10 commits into from
Nov 15, 2022

Conversation

standage
Copy link
Member

MicroHapDB's README has long served as a one-stop-shop for documentation. This PR adds a documentation suite (built with sphinx) that has permitted me to fill out the documentation a bit more. The new documentation includes dedicated pages for:

  • getting started
  • installation
  • statistics for ranking markers
  • details for configuring target sequences
  • brief Q&A with pointers to the dbbuild instructions for adding new markers and/or rebuilding the database from scratch
  • CLI reference
  • cited works

I've trimmed the README down a bit now that this information is included in dedicated documentation.

I'm attaching a copy of the rendered HTML docs here. Once this PR is merged, I'll configure ReadTheDocs to build and host the documentation automatically, as is done for MicroHapulator.

docs.zip

@@ -92,7 +92,6 @@ def display(result, view_format, delta=10, minlen=80, extend_mode=0, trunc=True,


def subparser(subparsers):
desc = microhapdb.cli.bubbletext + "\nRetrieve marker records by identifier or query"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bubbletext did not render well on the sphinx autodocs. It's still shown when microhapdb -h is run, but no longer when e.g. microhapdb marker -h is run.

@standage
Copy link
Member Author

No code changes to speak of in this PR, but @rnmitchell if you have time, I'd be interested in any feedback you have on the clarity of the documentation. Thanks!

@rnmitchell
Copy link
Contributor

Whenever I run make doc I run into this error:

sphinx-build -b html docs docs/_build/
Running Sphinx v5.1.1

Extension error:
Could not import extension myst_parser (exception: No module named 'myst_parser')
make: *** [doc] Error 2

@standage
Copy link
Member Author

Good catch. I need to update make devdeps to include sphinx, sphinx-argparse, and myst-parser. I'll update the Makefile, but in the meantime you can install those packages with conda or pip.

Copy link
Contributor

@rnmitchell rnmitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found a few small typos but otherwise looks great!

docs/ranking.md Outdated

The fixation index ($F_{ST}$) is computed on 26 global population groups.

The $I_n$ and F_{ST} statistics measure *between-population* allelic variation at a locus, which corresponds to the marker's utility for predicting population of origin.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this formatting of FST got messed up? Looks like it should be $F_{ST}$?

docs/targets.md Outdated
## Impacted outputs

MicroHapDB provides several different views for marker information.
This includes the default tabular summary format, a detailed human-readable description of the marker, a view for target sequences in Fasta format, and a table of the position of each marker's SNPs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very nitpicky but FASTA not Fasta to be correct :)

@standage
Copy link
Member Author

Good catches! Typos fixed.

Copy link
Contributor

@rnmitchell rnmitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@rnmitchell rnmitchell merged commit 49195e9 into master Nov 15, 2022
@standage standage deleted the dox branch November 15, 2022 20:01
@standage
Copy link
Member Author

Thank you for your careful review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants