CLI and build cleanup #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
standage
commented
Sep 13, 2023
Comment on lines
-81
to
+79
| subparser.add_argument( | ||
| "--format", choices=["table", "detail", "mhpl8r", "efm"], default="table" | ||
| ) | ||
| subparser.add_argument("--format", choices=["table", "mhpl8r", "efm"], default="table") |
There was a problem hiding this comment.
--format=detail support removed here.
| table = table.sort_values("Original").reset_index(drop=True) | ||
| table = table.sort_values(["Original", "Derivative"]).reset_index(drop=True) |
There was a problem hiding this comment.
merged.csv sorting updated here.
Comment on lines
-17
to
+21
| mh01WL-065,mh01WL-002 | ||
| mh01WL-055,mh01WL-002 | ||
| mh01WL-065,mh01WL-002 | ||
| mh01WL-049,mh01WL-003 | ||
| mh01WL-069,mh01WL-005 | ||
| mh01SCUZJ-0541700,mh01WL-005 | ||
| mh01WL-069,mh01WL-005 |
There was a problem hiding this comment.
Meaningless diffs caused by different row orders like this shouldn't be a problem after this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two small concerns.
microhapdb frequencyhas long had a documented--format=detailoption, which emits aNotImplementederror when invoked; this PR removes that as a documented option. Closes Implement detail view for frequency queries #79.merged.csvfile created during the database build is not consistent. This PR adds another sorting criterion to ensure that it is consistent. This doesn't have any impact on the contents of the database or the accuracy of its output, but it does eliminate distracting and uninformative diffs created each time the build procedure is run.