Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor database build #62

Merged
merged 17 commits into from
Jun 24, 2020
Merged

Refactor database build #62

merged 17 commits into from
Jun 24, 2020

Conversation

standage
Copy link
Member

This update substantially refactors the database build code:

  • eliminate duplication in database downloads
  • clean up Ae calculations and move them to sources/1kgp where they belong
  • retain per-population Ae values
  • update instructions for new snakemake --cores requirement

A big motivation for this is work is to facilitate inclusion of GRCh37 coordinates (#39). But I'm considering changes to the database schema for those updates, so I'm saving it for another PR.

@standage standage added datasources References to existing data sources or proposals for new sources refactoring Internal changes that don't alter behavior but make the software more robust and sustainable labels Jun 24, 2020
@standage standage merged commit e70ef36 into master Jun 24, 2020
@standage standage deleted the refactor/build branch June 24, 2020 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datasources References to existing data sources or proposals for new sources refactoring Internal changes that don't alter behavior but make the software more robust and sustainable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant