Testsuite is failing

[nileshpatra]

Hi @kortschak

Thanks a lot for your work on biogo. I maintain this as a package in Debian, and during a recent re-build, tests have started to fail for biogo, in particular these:

=== RUN   Test

----------------------------------------------------------------------
FAIL: errors_test.go:44: S.TestCaller

errors_test.go:49:
    c.Check(ln, check.Equals, 45)
... obtained int = 46
... expected int = 45

=== RUN   Test

----------------------------------------------------------------------
FAIL: fai_test.go:27: S.TestReadFrom

fai_test.go:178:
    c.Assert(err, check.DeepEquals, t.err)
... obtained *csv.ParseError = &csv.ParseError{StartLine:8, Line:8, Column:1, Err:(*errors.errorString)(0xc0000563f0)} ("record on line 8: wrong number of fields")
... expected *csv.ParseError = &csv.ParseError{StartLine:8, Line:8, Column:0, Err:(*errors.errorString)(0xc0000563f0)} ("record on line 8: wrong number of fields")
... Difference:
...     Column: 1 != 0


OOPS: 0 passed, 1 FAILED
--- FAIL: Test (0.00s)
FAIL
FAIL	github.com/biogo/biogo/io/seqio/fai	0.023s

Full log can be found here please consider fixing. There is some delta in col values that seems to trigger this, but I cannot do much beyond this point. Please consider fixing this, and thanks again!

[kortschak]

The issue is a result of changes in the way csv.Parser returns errors (https://go-review.googlesource.com/c/go/+/314774/). The fix is trivially to change the expected column, but I have limited time at the moment and this is not a package that I am actively using, so it may take some time to get to this.

In the interim, I don't see any problem with you altering that expect value in your build if you know that you are only supporting Go 1.17. The issue for the general fix is the infrastructure needed to make the expectation conditional on Go version.

[kortschak]

I have removed the tests from that package since it's been deprecated for a while and the actual logic is already tested elsewhere. I have also fixed or deprecated other failing issues.

[nileshpatra]

Thanks a lot. Would you please consider doing a point release with this fix? That'd help me pull the update and fix the corresponding debian package more cleanly. Let me know.

…

On Fri, 29 Oct, 2021, 2:10 pm Dan Kortschak, ***@***.***> wrote: I have removed the tests from that package since it's been deprecated for a while and the actual logic is already tested elsewhere. I have also fixed or deprecated other failing issues. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#85 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AI5T4HGZHUXCFJSHZLWCLDDUJJMYDANCNFSM5GVKPCOQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[kortschak]

Would a v1.0.4 work for you? There are no functional changes.

[nileshpatra]

Sure, that'd be great!

…

On Fri, 29 Oct, 2021, 2:27 pm Dan Kortschak, ***@***.***> wrote: Would a v1.0.4 work for you? There are no functional changes. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#85 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AI5T4HAD5OEIEGNN2D5PAN3UJJOXPANCNFSM5GVKPCOQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.