Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More tf features #176

Merged
merged 12 commits into from
Dec 1, 2021
Merged

More tf features #176

merged 12 commits into from
Dec 1, 2021

Conversation

constantinpape
Copy link
Contributor

Fixes #175

github-actions[bot]
github-actions bot reviewed Dec 1, 2021
View reviewed changes
bioimageio/core/__main__.py Outdated Show resolved Hide resolved
bioimageio/core/__main__.py Show resolved Hide resolved
bioimageio/core/build_spec/build_model.py Outdated Show resolved Hide resolved
bioimageio/core/build_spec/build_model.py Outdated Show resolved Hide resolved
bioimageio/core/prediction_pipeline/_model_adapters/_keras_model_adapter.py Show resolved Hide resolved
bioimageio/core/weight_converter/keras/tensorflow.py Outdated Show resolved Hide resolved
bioimageio/core/weight_converter/keras/tensorflow.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/weight_converter/keras/test_tensorflow.py Outdated Show resolved Hide resolved
tests/weight_converter/torch/test_torchscript.py Outdated Show resolved Hide resolved
@constantinpape
Copy link
Contributor Author

Also adds a weight converter for keras->tf weights.
Does not check the onnx version in prediction, I will create a separate issue on this.

constantinpape and others added 3 commits December 1, 2021 20:11
@constantinpape @github-actions
Apply suggestions from code review
6dba202 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@constantinpape
Use mamba to resolve tf env
7d5b7e8
@constantinpape
Merge branch 'more-tf-features' of https://github.com/bioimage-io/pyt…
585859d 
…hon-bioimage-io into more-tf-features
@github-actions github-actions bot added ci Continuous Integration github_actions Pull requests that update Github_actions code labels Dec 1, 2021
@constantinpape
Copy link
Contributor Author

I had to change to mamba for the tf env, conda couldn't resolve it. I left it as conda for the other envs for now.

@constantinpape
Copy link
Contributor Author

all relevant tests pass, so I am gonna merge it.

@constantinpape constantinpape merged commit 06ec7d5 into main Dec 1, 2021
@FynnBe FynnBe deleted the more-tf-features branch December 1, 2021 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

@FynnBe FynnBe Awaiting requested review from FynnBe

Assignees
No one assigned
Labels
ci Continuous Integration github_actions Pull requests that update Github_actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better handling of tf version
1 participant
@constantinpape