Bugfix: chromosome mapping tool #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
valasatava
commented
Feb 23, 2017
valasatava
commented
- Fix in the chromosome mapping tool to return -1 if the genomic position falls outside coding region on the forward strand
- Test is added to check if the boundaries are handled correctly
…coding region on the forward strand
andreasprlic
requested changes
Feb 23, 2017
|
|
||
| int cdsEE = ChromosomeMappingTools.getCDSPosForChromosomeCoordinate(posExonEnd+1, gcp); | ||
| assertEquals(cdsEE, -1); | ||
|
|
There was a problem hiding this comment.
Can you also add a check that the CDS position for first base in the coding region is correct?
added 2 commits
February 23, 2017 16:15
…e position on mRNA for the genes leaving on the forward strand
…for the genes leaving on the forward strand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.