Limited max content length of dropdowns and report in interactive k-means #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
==========================================
+ Coverage 95.57% 95.58% +0.01%
==========================================
Files 15 15
Lines 1739 1743 +4
Branches 209 210 +1
==========================================
+ Hits 1662 1666 +4
Misses 54 54
Partials 23 23
Continue to review full report at Codecov.
|
PrimozGodec
force-pushed
the
kmeans-update
branch
from
fcb3beb
to
b701301
Compare
kernc
reviewed
Sep 23, 2016
| @@ -174,12 +175,11 @@ def __init__(self): | |||
| self.options_box = gui.widgetBox(self.controlArea, "Data") | |||
| opts = dict( | |||
| widget=self.options_box, master=self, orientation=Qt.Horizontal, | |||
| callback=self.restart, sendSelectedValue=True) | |||
| callback=self.restart, sendSelectedValue=True, | |||
| maximumContentsLength=15) | |||
| policy = QSizePolicy(QSizePolicy.MinimumExpanding, QSizePolicy.Fixed) | |||
There was a problem hiding this comment.
It was used on a spinner, but it is not required so I removed it.
kernc
force-pushed
the
kmeans-update
branch
2 times, most recently
from
19e66d7
to
eae203f
Compare
… in interactive k-means
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this pull request we: