[ENH] Save painted data to schema #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 87.91%@@ master #1452 diff @@
==========================================
Files 77 77
Lines 7582 7582
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 6666 6666
Misses 916 916
Partials 0 0
|
|
Works great, thanks! Tiny bug: paint the data, set Send to Send Automatically, connect scatter plot to Paint Data, save the workflow. Open the saved worflow, the data is in Paint Data, but although Send Automatically is on the data has not been sent out from the widget (scatter plot is empty). |
astaric
force-pushed
the
schema-only-settings
branch
from
63bb169
to
e92ff85
Compare
|
Perhaps while fixing the bug above, there is another one somehow related: after Undo, this widget does not commit the data when Send Automatically is on. |
Schema_only settings are saved in schema, but do not change their default values, so new widget always start with the same (empty) default value.
astaric
force-pushed
the
schema-only-settings
branch
from
e92ff85
to
0e85a3b
Compare
Remove invalidate in newtool.editingFinished to avoid sending the data twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a concept of schema only setting - a setting that does not update its defaults, but is still saved with schema.
Use schema only setting to store painted points in PaintData widget.
Fixes #1451