test_owtestandscore: Fix testandscore test mock #5530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irgolic
force-pushed
the
fix-testandscore-test-mock
branch
from
ae9799e
to
a2055b6
Compare
irgolic
force-pushed
the
fix-testandscore-test-mock
branch
from
a2055b6
to
591d745
Compare
Codecov Report
@@ Coverage Diff @@
## master #5530 +/- ##
=======================================
Coverage 86.37% 86.38%
=======================================
Files 304 304
Lines 61753 61753
=======================================
+ Hits 53341 53344 +3
+ Misses 8412 8409 -3 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This test was failing with a stack overflow here #5208. Not sure why it wasn't failing elsewhere, going through the trace on windows seems pretty sensible to fail.
Description of changes
Changes the mocked object to the correct one (thanks @janezd)
Includes