Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mosaic VizRank: Start when opened, pause when closed #6632

Closed
wants to merge 6 commits into from

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Nov 10, 2023

Issue

Ref. #6504. I also strongly suspect

Based on #6614 (for pause_when_closed flag, and for CloseVizrankMixin). Only the last commit is new.

@processo was totally right in #6504. I knew that closing VizRank doesn't stop it, but I expected that closing the widget would. Of course it doesn't, and in case of Mosaic, which rapidly fills the table model and fires signals, it blocks the main thread, making Orange basically unresponsive even after the widget is closed and everything should have been silent.

When #6612 or alike is merged, we should prevent vizranks from sending such frequent updates.

Description of changes

Changes are similar to those made to vizranks in #6614.

Includes
  • Code changes
  • Tests
  • Documentation

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #6632 (5970064) into master (df20f2e) will decrease coverage by 0.02%.
Report is 2 commits behind head on master.
The diff coverage is 82.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6632      +/-   ##
==========================================
- Coverage   88.10%   88.08%   -0.02%     
==========================================
  Files         321      321              
  Lines       69876    69906      +30     
==========================================
+ Hits        61563    61578      +15     
- Misses       8313     8328      +15     

@janezd janezd closed this Nov 10, 2023
@janezd janezd deleted the mosaic-vizrank-start branch November 10, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant