Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linear projection plot scoring keeps running after window is closed #6504

Closed
processo opened this issue Jul 10, 2023 · 3 comments · Fixed by #6661
Closed

Linear projection plot scoring keeps running after window is closed #6504

processo opened this issue Jul 10, 2023 · 3 comments · Fixed by #6661
Assignees
Labels
meal This will take a day or two wish

Comments

@processo
Copy link

Not sure if this is intended or not, but when I start a search in Linear projection (Suggest features) if I don't pause it it will keep running even when the Linear projection's window is closed.

How to reproduce:

  1. open Linear projection, Suggest features, start
  2. close Score plots window
  3. close Linear projection window
  4. it is still running in the background (with no progress indicator around the widget icon)
  5. you can open Linear projection again, open Suggest features and see it running

OS: Windows 10 x64
Orange: 3.35.0

@processo processo added the bug report Bug is reported by user, not yet confirmed by the core team label Jul 10, 2023
@janezd
Copy link
Contributor

janezd commented Aug 17, 2023

This works as intended. Closing the window was not meant to stop the optimization, and the progress bar in widgets refers to what is happening in the widget, not in another window.

Both can be changed. One could argue that the user who closes window intends to cancel the optimization, and one could argue even more that widgets that suggest feature should have a progress bar. We'll discuss this.

@janezd janezd added needs discussion Core developers need to discuss the issue and removed bug report Bug is reported by user, not yet confirmed by the core team labels Aug 17, 2023
@janezd janezd self-assigned this Aug 18, 2023
@janezd
Copy link
Contributor

janezd commented Aug 18, 2023

We discussed this. If the computation is started by pressing a button (not by opening a window) it should also be stopped/paused by pressing a button (not closing a window). On the other hand, others also said that they expected that closing the window would stop the computation.

  1. We decided to check the existing widgets that offer this functionality and see whether we could change them to start the calculation immediately.
  2. A progress bar would be useful, but it's not the widget's "main" progress bar. Instead, the bar should be around/under/in the button Suggest Features. Ideally, the button background could serve as a bar, though this is hard to do in Qt. (A hack by @ales-erjavec in a pull request for showing uncommitted signals could be useful here.)

Thanks for your comment. We'll do something about this.

@janezd janezd added wish meal This will take a day or two and removed needs discussion Core developers need to discuss the issue labels Aug 18, 2023
@janezd janezd removed their assignment Aug 18, 2023
@janezd
Copy link
Contributor

janezd commented Aug 24, 2023

Re 1: Unless I overlooked any, widgets with a VizRank-like buttons are Linear projection, Radviz, Mosaic, Sieve, Scatter plot. The last two are not a problem, while the first three allow the user to control the number of variables. The corresponding spin/combo is disabled while the widget is running. If vizrank starts immediatelly then my concern is that the user may not be aware that it can enable the control by stopping (pausing) the computation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meal This will take a day or two wish
Projects
None yet
2 participants