-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need more application-friendly views of phenotype facet counts. #123
Comments
Per recent email discussion; I've opted to hard code the top level categories and labels for now. Please see the file here. |
Note this could apply to other routes, prototyping here first
creates a new dict in the
|
Yes this is a challenge, but maybe the intention is to only generate this view for leaf nodes?
Maybe we can mock up something quick with plotly to see if it's even worth doing this since frequency/severity/onset annotations are sparse |
if we restricted to leaf or leafy disease nodes then we could be confident a call to fetch all objects would be timely, and then propagate up in biolink using the ontology But this seems restrictive, we want this to work for intermediate level nodes. And also for things other than disease freq: good point |
@jmcmurry @cmungall here is a plotly mock up of the phenotype breakdown. It uses a threshold configuration (freqThreshold) to determine whether to show a breakdown of frequency information. As configured, if more than 5% of phenotype annotations have frequency annotations it shows a stacked barchart. |
probably duplicate of obophenotype/human-phenotype-ontology#2474 probably duplicate of obophenotype/human-phenotype-ontology#3375 should we close the other tickets? |
The current calls for phenotypes for an entity (https://api.monarchinitiative.org/api/bioentity/disease/OMIM%3A605543/phenotypes/?fetch_objects=true&rows=300) return a lot of ceremony, which, while not untrue data, is not particularly useful for the UI.
These additional things include but are not limited to owl:thing, BFO classes, etc. While the long game may be for there to be annotation properties directly on UPheno classes, the short term fix would be to have some hardcoded interpreter within biolink that filters out the cruft.
Ideally, I would like to see the minimalist labels related, where appropriate, to the anatomical systems implicated.
Eg specifically:
Moreover the sorts of categories I would expect to see, I do not see at all.
eye, face, pulmonary
The text was updated successfully, but these errors were encountered: