Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "OBO" prefix mapping #760

Closed
balhoff opened this issue Jun 2, 2021 · 5 comments
Closed

remove "OBO" prefix mapping #760

balhoff opened this issue Jun 2, 2021 · 5 comments
Labels
enhancement identifiers Used to group tickets around prefix management and identifier mappings mapping working-group/KGE knowledge graph exchange. slack channel is #knowledge-graph-exchange-working-group

Comments

@balhoff
Copy link
Contributor

balhoff commented Jun 2, 2021

I'm wondering if anyone else agrees that we should remove the "OBO": "http://purl.obolibrary.org/obo/" prefix mapping. To me it's a bad practice for one prefix expansion to overlap another. There are many other prefix expansions that include http://purl.obolibrary.org/obo/ as a substring. Anywhere that Biolink model needs to refer to an OBO term, it should use the specific ontology prefixes.

I noticed this in implementing the MetaKnowledgeGraph service for the Ontology KP; I end up with OBO as a valid prefix for nearly every Biolink category, which is not useful.

@saramsey
Copy link
Contributor

saramsey commented Jun 2, 2021

Hi Jim, there are URLs in OBO ontology sources that we use, that reduce to CURIEs like OBO:core#connected_to. For example, this in uberon-ext.owl (line 3472):

<owl:ObjectProperty rdf:about="http://purl.obolibrary.org/obo/core#connected_to"/>

How would this URL be shortened?

@cmungall
Copy link
Collaborator

cmungall commented Jun 3, 2021

If you could report these on the uberon tracker, this would be great

(I know exactly where these are coming from. Most of uberon uses the RO relation. But there was an uberon module that dealt with fish and dinosaurs that was managed sepparately and when we merged it in some relation IDs didn;t mesh)

any of the following work

  • drop until fixed upstream. I promise you spatial connections between bones of extinct vertebrates probably isn't the most relevant edge type in translator, cool as they are :-)
  • keep the full URI
  • we create a prefix UBERON.NONAMESPACE => http://purl.obolibrary.org/obo/core#

@balhoff
Copy link
Contributor Author

balhoff commented Jun 3, 2021

Thanks for the feedback @saramsey! I favor Chris's last suggestion, adding UBERON.NONAMESPACE => http://purl.obolibrary.org/obo/core#. We can still also fix the IDs at the source (Uberon).

There are a few others, for example OBO:envo#has_increased_levels_of, which I think we can handle the same way we did for similar relations in PATO:

PATO-PROPERTY: 'http://purl.obolibrary.org/obo/pato#'

All of these kinds of ids are really mistakes from the OBO Foundry perspective, and we (OBO) should get around to fixing them.

There are some that I think can be changed or removed:

  • OBO:xref => should be OIO:hasDbXref, which is what the OBO file syntax xref translates to
  • OBO:intersection_of => this is part of the OBO file format but not a legitimate relation on its own

What do you think?

As an aside, I also noticed we have multiple mappings to the same expansion:

  • "oboInOwl": "http://www.geneontology.org/formats/oboInOwl#"
  • "oboformat": "http://www.geneontology.org/formats/oboInOWL#" (almost! this one is just a mistake)
  • "OIO": "http://www.geneontology.org/formats/oboInOwl#"

I'm not sure what the policy is here.

@sierra-moxon sierra-moxon added enhancement working-group/KGE knowledge graph exchange. slack channel is #knowledge-graph-exchange-working-group labels Jun 4, 2021
@balhoff
Copy link
Contributor Author

balhoff commented Jun 8, 2021

I'm working on getting rid of those problem Uberon relations: obophenotype/uberon-phenoscape-ext#26, obophenotype/uberon-phenoscape-ext#27

@nlharris nlharris added mapping identifiers Used to group tickets around prefix management and identifier mappings labels Jun 11, 2021
@sierra-moxon sierra-moxon added release-2.3.0 release-2.3.0 and removed release-2.3.0 release-2.3.0 labels Jul 20, 2021
@sierra-moxon
Copy link
Member

sierra-moxon commented Oct 25, 2021

@balhoff @saramsey, so the solution here is to replace the following prefixes with the new expansions?
OBO:nbo# with prefix NBO-PROPERTY ('http://purl.obolibrary.org/obo/nbo#')
OBO:doid# with prefix DOID-PROPERTY ('http://purl.obolibrary.org/obo/doid#')
OBO:uo# with prefix UO-PROPERTY ('http://purl.obolibrary.org/obo/uo#')
OBO:core# with prefix UBERON.NONAMESPACE ('http://purl.obolibrary.org/obo/core#')

OBO:xref -> OIO:hasDbXref

I don't have a good handle on the downstream ramifications of removing oboformat as a prefix or replacing oboInOwl with OIO. @cmungall is there a preferred option here?

(This PR attempts to do the work above).

sierra-moxon added a commit that referenced this issue Nov 8, 2021
replace OBO prefix with more specific prefixes fixes #793 fixes #760
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement identifiers Used to group tickets around prefix management and identifier mappings mapping working-group/KGE knowledge graph exchange. slack channel is #knowledge-graph-exchange-working-group
Projects
None yet
Development

No branches or pull requests

5 participants