New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove "OBO" prefix mapping #760
Comments
Hi Jim, there are URLs in OBO ontology sources that we use, that reduce to CURIEs like
How would this URL be shortened? |
If you could report these on the uberon tracker, this would be great (I know exactly where these are coming from. Most of uberon uses the RO relation. But there was an uberon module that dealt with fish and dinosaurs that was managed sepparately and when we merged it in some relation IDs didn;t mesh) any of the following work
|
Thanks for the feedback @saramsey! I favor Chris's last suggestion, adding There are a few others, for example
All of these kinds of ids are really mistakes from the OBO Foundry perspective, and we (OBO) should get around to fixing them. There are some that I think can be changed or removed:
What do you think? As an aside, I also noticed we have multiple mappings to the same expansion:
I'm not sure what the policy is here. |
I'm working on getting rid of those problem Uberon relations: obophenotype/uberon-phenoscape-ext#26, obophenotype/uberon-phenoscape-ext#27 |
@balhoff @saramsey, so the solution here is to replace the following prefixes with the new expansions? OBO:xref -> OIO:hasDbXref I don't have a good handle on the downstream ramifications of removing oboformat as a prefix or replacing oboInOwl with OIO. @cmungall is there a preferred option here? (This PR attempts to do the work above). |
I'm wondering if anyone else agrees that we should remove the
"OBO": "http://purl.obolibrary.org/obo/"
prefix mapping. To me it's a bad practice for one prefix expansion to overlap another. There are many other prefix expansions that includehttp://purl.obolibrary.org/obo/
as a substring. Anywhere that Biolink model needs to refer to an OBO term, it should use the specific ontology prefixes.I noticed this in implementing the MetaKnowledgeGraph service for the Ontology KP; I end up with
OBO
as a valid prefix for nearly every Biolink category, which is not useful.The text was updated successfully, but these errors were encountered: