Issue 338 enhanced kgx transform logging #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 24 commits
November 22, 2021 17:16
…) and applied to graph-summary classes
… to fix the static ValidationError methods now?)
… add singleton Validator; completely internalize error reporting inside the ErrorDetector class
…leases (won't test more ancient releases)
…o 'get_errors_catalog' (but only the old function... not the code using it)
…l dependency (should be updated by LinkML but...)
…porting; however, "flat" output is still a bit too verbose. Time to inject JSON hierarchy?
…ut, for use by 'validate' and 'graph-summary' KGX commands
…or tech debt repair
…sformer as 'owner' of Source and Sink instances, so as to provide access to global error logging inside those instances
…e log.info with "owner" Transformer log_error calls
… reporting feature; added optional 'level' argument to get_errors() and write_report() methods in ErrorDetecting class
…e.NO_CATEGORY' to MISSING_CATEGORY
sierra-moxon
approved these changes
Jan 15, 2022
|
SonarCloud Quality Gate failed. |
|
Thanks @sierra-moxon ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolution of #338.
Application of KGX ErrorDetecting class to Transformer, Source and Sink classes, to provide more uniform error log reporting (similar to the validate and graph-summary modes).